HomePhabricator

hgweb: cast bytearray to bytes

Authored by indygreg.

Description

hgweb: cast bytearray to bytes

PEP-3333 seems to indicate that bytes is the only allowed type that can
be used to express the output of a WSGI application. And some WSGI
environments seem to enforce this (mod_wsgi does).

This commit universally casts bytearray instances to bytes to appease
the WSGI specification.

I found this because wireprotov2 is emitting bytearray instances. I'd
like to keep things that way because the way it builds a data
structure, bytearray is more efficient. I'd rather keep the low-level
code efficient (and using bytearray) and cast at the edges than impose
a performance penalty on code that may run outside WSGI contexts.

Details

Committed
indygregNov 9 2018, 6:49 PM
Parents
rHG5b530d767e67: help: unjumble the list of default config values for `internals.config`
Branches
Unknown
Tags
Unknown