HomePhabricator

server: ensure the incoming request falls under the prefix value

Authored by mharbison72.

Description

server: ensure the incoming request falls under the prefix value

Prior to this, the first test asserted in wsgiref.validate.check_environ()
saying PATH didn't start with '/', but the second test served up the repo. The
assertion was just added in this cycle (though the value of PATH is still wrong
without the assertion). Allowing access to the repo at any URL outside of the
prefix is a long standing bug. This also affected hgwebdir, at least when used
via --subrepo.

Paths are not being canonicalized, so accesses to things like 'foo/../bar' will
get tossed out here, unless the prefix also matches.

Details

Committed
mharbison72Apr 1 2018, 1:27 AM
Parents
rHG177f3b90335f: rebase: on abort, don't strip commits that didn't need rebased (issue5822)
Branches
Unknown
Tags
Unknown