HomePhabricator

revlog: open files in 'r+' instead of 'a+'

Authored by marmoute.

Description

revlog: open files in 'r+' instead of 'a+'

The code doing actual writing is already doing the necessary seeking, so we
could safely use 'r+'. This make the file objecs usable in more situation, like
updating the sidedata information during pull.

revlog: forcibly move the file cursor at the right location before writing

This is a paranoid change in case the changelog computation moved the cursors
under our feets.

This is not known to happens right now.

Differential Revision: https://phab.mercurial-scm.org/D10608

Details

Committed
marmouteMay 3 2021, 6:28 AM
Differential Revision
D10608: revlog: open files in 'r+' instead of 'a+'
Parents
rHG2bd4b5218918: revlog: pass a transaction object to `rewrite_sidedata`
Branches
Unknown
Tags
Unknown