dirstate-item: replace call to new_from_p2
The constructor is on its way out, so we inline the last relevant call before dropping it.
Differential Revision: https://phab.mercurial-scm.org/D11602