HomePhabricator

bookmarks: actual fix for race condition deleting bookmark

Authored by marmoute.

Description

bookmarks: actual fix for race condition deleting bookmark

This is a simple but efficient fix to prevent the issue tested in
test-bookmarks-corner-case.t. It might be worth pursuing a more generic
approach where filecache learn to depend on each other, but that would not be
suitable for stable.

The issue is complicated enough that I documented the race and its current
solution as inline comment. See this comment for details on the fix.

Details

Committed
marmouteJun 20 2019, 9:50 PM
Parents
rHGa1f10edcf6a6: strip: access bookmark before getting a reference to changelog
Branches
Unknown
Tags
Unknown