Page MenuHomePhabricator

remotefilelog: prevent file download to deadlock on windows
AbandonedPublic

Authored by klevesque on May 7 2021, 9:02 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

When fetching a big file on Windows, the buffer gets full, which results on a
deadlock. To prevent this, we fetch the data hunk by chunk until all the data
has been retrieved.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

klevesque created this revision.May 7 2021, 9:02 AM
klevesque abandoned this revision.May 14 2021, 5:13 PM

I found out the the bug was cause by the fact that I was using an old version of MSYS2. It doesn't happen with a recent one.