This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5934

phabricator: make user searches case-insensitive
ClosedPublic

Authored by jcristau on Feb 11 2019, 10:28 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG570e62f1dcf2: phabricator: make user searches case-insensitive
Summary

User names in conduit are case insensitive, but when looking for "FOO"
it would return "foo" instead and we'd think the user didn't exist. So
lower case both the query and the response when comparing them.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jcristau created this revision.Feb 11 2019, 10:28 AM
Closed by commit rHG570e62f1dcf2: phabricator: make user searches case-insensitive (authored by jcristau). · Explain WhyFeb 15 2019, 4:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (3 lines)

Diff 14110

hgext/phabricator.py

revision = callconduit(repo, b'differential.revision.edit', params) revision = callconduit(repo, b'differential.revision.edit', params)
if not revision: if not revision:
raise error.Abort(_(b'cannot create revision for %s') % ctx) raise error.Abort(_(b'cannot create revision for %s') % ctx)
return revision, diff return revision, diff
def userphids(repo, names): def userphids(repo, names):
"""convert user names to PHIDs""" """convert user names to PHIDs"""
names = [name.lower() for name in names]
query = {b'constraints': {b'usernames': names}} query = {b'constraints': {b'usernames': names}}
result = callconduit(repo, b'user.search', query) result = callconduit(repo, b'user.search', query)
# username not found is not an error of the API. So check if we have missed # username not found is not an error of the API. So check if we have missed
# some names here. # some names here.
data = result[r'data'] data = result[r'data']
resolved = set(entry[r'fields'][r'username'] for entry in data) resolved = set(entry[r'fields'][r'username'].lower() for entry in data)
unresolved = set(names) - resolved unresolved = set(names) - resolved
if unresolved: if unresolved:
raise error.Abort(_(b'unknown username: %s') raise error.Abort(_(b'unknown username: %s')
% b' '.join(sorted(unresolved))) % b' '.join(sorted(unresolved)))
return [entry[r'phid'] for entry in data] return [entry[r'phid'] for entry in data]
@vcrcommand(b'phabsend', @vcrcommand(b'phabsend',
[(b'r', b'rev', [], _(b'revisions to send'), _(b'REV')), [(b'r', b'rev', [], _(b'revisions to send'), _(b'REV')),