This is an archive of the discontinued Mercurial Phabricator instance.

chg: close file descriptors when starting the daemon

Authored by Mathiasdm on Nov 2 2020, 8:20 AM.



It's good practice to close file descriptors when forking to start a daemon.
This did not appear to happen yet, which results in flock hanging
in one location in our system (because the chg daemon keeps
the locked file open).

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mathiasdm created this revision.Nov 2 2020, 8:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.