This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11228

tests: make test-serve works on system that allow user to bind low port
ClosedPublic

Authored by marmoute on Jul 29 2021, 5:11 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa8deb9dc39da: tests: make test-serve works on system that allow user to bind low port
Summary

It is possible to encounter linux system configured in a way that allow port
< 1024 to be bound by any users. So we update a test to focus more on the actual
test: "resolving daytime to an actual port number.

The new auto-scaling CI runner provided by clever cloud is doing so. This is the
initial motivation for this change, but it seems useful anyway.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 29 2021, 5:11 AM
marmoute added a commit: rHGa8deb9dc39da: tests: make test-serve works on system that allow user to bind low port.Jul 30 2021, 11:11 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGa8deb9dc39da: tests: make test-serve works on system that allow user to bind low port (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-serve.t (15 lines)

Diff 29751

tests/test-serve.t

% errors % errors
With -v and -p HGPORT2 With -v and -p HGPORT2
$ hgserve -p "$HGPORT2" $ hgserve -p "$HGPORT2"
listening at http://localhost/ (bound to *$LOCALIP*:HGPORT2) (glob) (?) listening at http://localhost/ (bound to *$LOCALIP*:HGPORT2) (glob) (?)
% errors % errors
With -v and -p daytime (should fail because low port) With -v and -p daytime
#if no-root no-windows # On some system this will fails because port < 1024 are not bindable by normal
# users.
#
# On some others the kernel is configured to allow any user to bind them and
# this will work fine
#if no-windows
$ KILLQUIETLY=Y $ KILLQUIETLY=Y
$ hgserve -p daytime $ hgserve -p daytime
abort: cannot start server at 'localhost:13': Permission denied abort: cannot start server at 'localhost:13': Permission denied (?)
abort: child process failed to start abort: child process failed to start (?)
listening at http://localhost/ (bound to $LOCALIP:13) (?)
% errors % errors
$ KILLQUIETLY=N $ KILLQUIETLY=N
#endif #endif
With --prefix foo With --prefix foo
$ hgserve --prefix foo $ hgserve --prefix foo
listening at http://localhost/foo/ (bound to *$LOCALIP*:HGPORT1) (glob) (?) listening at http://localhost/foo/ (bound to *$LOCALIP*:HGPORT1) (glob) (?)