This is an archive of the discontinued Mercurial Phabricator instance.

revlog: fix more type confusion in index_replace_sidedata_info (issue6580)

Authored by jcristau on Aug 24 2021, 5:45 PM.



We were telling python that "rev" was a Py_ssize_t (via the "n" format),
but it was actually an int.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jcristau created this revision.Aug 24 2021, 5:45 PM

Thanks again for finding this. I have no idea why I started using n all of a sudden where the rest of the code is using i (with an int). Using n (with the correct type, of course) might be strictly better even though it doesn't really matter, so I guess we'll stick with it.

Alphare accepted this revision.Aug 25 2021, 4:56 AM
This revision is now accepted and ready to land.Aug 25 2021, 4:56 AM