| hg-reviewers |
See inline comments
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| extern crate log; | extern crate log; | ||||
| use crate::error::CommandError; | use crate::error::CommandError; | ||||
| use crate::ui::Ui; | use crate::ui::Ui; | ||||
| use clap::App; | use clap::App; | ||||
| use clap::AppSettings; | use clap::AppSettings; | ||||
| use clap::Arg; | use clap::Arg; | ||||
| use clap::ArgMatches; | use clap::ArgMatches; | ||||
| use format_bytes::{format_bytes, join}; | use format_bytes::{format_bytes, join}; | ||||
| use hg::config::{Config, ConfigSource}; | use hg::config::{Config, ConfigSource}; | ||||
| use hg::exit_codes; | use hg::exit_codes; | ||||
| use hg::repo::{Repo, RepoError}; | use hg::repo::{Repo, RepoError}; | ||||
| use hg::utils::files::{get_bytes_from_os_str, get_path_from_bytes}; | use hg::utils::files::{get_bytes_from_os_str, get_path_from_bytes}; | ||||
| use hg::utils::SliceExt; | use hg::utils::SliceExt; | ||||
| use std::collections::HashSet; | |||||
| use std::ffi::OsString; | use std::ffi::OsString; | ||||
| use std::path::PathBuf; | use std::path::PathBuf; | ||||
| use std::process::Command; | use std::process::Command; | ||||
| mod blackbox; | mod blackbox; | ||||
| mod error; | mod error; | ||||
| mod ui; | mod ui; | ||||
| pub mod utils { | pub mod utils { | ||||
| Some(_) => { | Some(_) => { | ||||
| // TODO: warn about unknown config value | // TODO: warn about unknown config value | ||||
| Self::DEFAULT | Self::DEFAULT | ||||
| } | } | ||||
| } | } | ||||
| } | } | ||||
| } | } | ||||
| /// The `*` extension is an edge-case for config sub-options that apply to all | |||||
| /// extensions. For now, only `:required` exists, but that may change in the | |||||
| /// future. | |||||
| const SUPPORTED_EXTENSIONS: &[&[u8]] = | const SUPPORTED_EXTENSIONS: &[&[u8]] = | ||||
| &[b"blackbox", b"share", b"sparse", b"narrow"]; | &[b"blackbox", b"share", b"sparse", b"narrow", b"*"]; | ||||
| fn check_extensions(config: &Config) -> Result<(), CommandError> { | fn check_extensions(config: &Config) -> Result<(), CommandError> { | ||||
| let enabled = config.get_section_keys(b"extensions"); | let enabled: HashSet<&[u8]> = config | ||||
| .get_section_keys(b"extensions") | |||||
| .into_iter() | |||||
| .map(|extension| { | |||||
| // Ignore extension suboptions. Only `required` exists for now. | |||||
| // `rhg` either supports an extension or doesn't, so it doesn't | |||||
| // make sense to consider the loading of an extension. | |||||
| extension.split_2(b':').unwrap_or((extension, b"")).0 | |||||
| }) | |||||
| .collect(); | |||||
| let mut unsupported = enabled; | let mut unsupported = enabled; | ||||
| for supported in SUPPORTED_EXTENSIONS { | for supported in SUPPORTED_EXTENSIONS { | ||||
| unsupported.remove(supported); | unsupported.remove(supported); | ||||
| } | } | ||||
| if let Some(ignored_list) = config.get_list(b"rhg", b"ignored-extensions") | if let Some(ignored_list) = config.get_list(b"rhg", b"ignored-extensions") | ||||
| { | { | ||||
| $ touch .hgsub | $ touch .hgsub | ||||
| $ $NO_FALLBACK rhg files | $ $NO_FALLBACK rhg files | ||||
| unsupported feature: subrepos (.hgsub is present) | unsupported feature: subrepos (.hgsub is present) | ||||
| [252] | [252] | ||||
| $ rhg files | $ rhg files | ||||
| a | a | ||||
| $ rm .hgsub | $ rm .hgsub | ||||
| The `:required` extension suboptions are correctly ignored | |||||
| $ echo "[extensions]" >> $HGRCPATH | |||||
| $ echo "blackbox:required = yes" >> $HGRCPATH | |||||
| $ rhg files | |||||
| a | |||||
| $ echo "*:required = yes" >> $HGRCPATH | |||||
| $ rhg files | |||||
| a | |||||