This is an archive of the discontinued Mercurial Phabricator instance.

rhg: refactor to pass argv down, instead of caling args_os()
AcceptedPublic

Authored by aalekseyev on Tue, Apr 12, 3:02 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

This refactoring makes it easy to patch some command-line preprocessing into rhg.
We use this to support using rhg as a shebang interpreter, for example.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

aalekseyev created this revision.Tue, Apr 12, 3:02 PM
Alphare added inline comments.
rust/rhg/src/main.rs
390–391

Nitpicking: why is this "b? This implies some other 'a lifetime by convention.

aalekseyev updated this revision to Diff 33146.Wed, Apr 13, 5:41 AM
aalekseyev marked an inline comment as done.Wed, Apr 13, 5:44 AM
aalekseyev added inline comments.
rust/rhg/src/main.rs
390–391

Changed it now.
(I guess the name 'a must have been taken when I wrote it. \shrug)

Alphare accepted this revision.Thu, Apr 14, 4:36 AM
This revision is now accepted and ready to land.Thu, Apr 14, 4:36 AM