Page MenuHomePhabricator

metaedit: switch to scmutil.cleanupnodes for cleanup
ClosedPublic

Authored by mitrandir on Jul 27 2017, 8:51 AM.

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX397926ee66b0: metaedit: switch to scmutil.cleanupnodes for cleanup
Summary

That switches us to use the higher level abstractions and allows us to
beneefit from things like showupdated (see: D173)

Test Plan

ran metaedit tests

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mitrandir created this revision.Jul 27 2017, 8:51 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2017, 8:51 AM
quark accepted this revision.Jul 27 2017, 1:15 PM
quark added a subscriber: quark.

And it works without obsstore now!

This revision is now accepted and ready to land.Jul 27 2017, 1:15 PM
quark added inline comments.Jul 27 2017, 1:18 PM
hgext3rd/fbamend/metaedit.py
165–167

rev needs to be changed to node to get correct bookmark movement behavior

mitrandir updated this revision to Diff 452.Jul 31 2017, 11:51 AM

changes revs to nodes in the mapping

This revision was automatically updated to reflect the committed changes.