This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1936

p4fastimport: report more information about unsupported p4 file actions
Needs ReviewPublic

Authored by hollisb on Jan 22 2018, 7:04 PM.

Download Raw Diff

Details

Reviewers

dsp

Group Reviewers

Restricted Project

Summary

No matter what, users and developers need this information to understand the
problem.

Diff Detail

Repository

rFBHGX Facebook Mercurial Extensions

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

hollisb created this revision.Jan 22 2018, 7:04 PM

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2018, 7:04 PM

I will have a followup patch to handle 'purge' file actions at some point, but it's not yet clear to me how to do it in the most useful and nonsurprising way. :-) In the meantime, this is a useful step.

Revision Contents
Changeset List

			Path	Packages
M			hgext3rd/p4fastimport/p4.py (3 lines)

Diff 5000

hgext3rd/p4fastimport/p4.py

	for fname, info in self.parsed['files'].iteritems():			for fname, info in self.parsed['files'].iteritems():
	if info['action'] in ACTION_EDIT:			if info['action'] in ACTION_EDIT:
	m.append(fname)			m.append(fname)
	elif info['action'] in ACTION_ADD:			elif info['action'] in ACTION_ADD:
	a.append(fname)			a.append(fname)
	elif info['action'] in ACTION_DELETE + ACTION_ARCHIVE:			elif info['action'] in ACTION_DELETE + ACTION_ARCHIVE:
	r.append(fname)			r.append(fname)
	else:			else:
	assert False			msg = 'unsupported action "%s" in changelist %s for file %s'
				raise P4Exception(msg % (info['action'], self._clnum, fname))
	return a, m, r			return a, m, r

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5000			Jan 22 2018, 7:04 PM	★	★