This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2727

bookmarks: test for exchanging long bookmark names (issue5165)
ClosedPublic

Authored by durin42 on Mar 8 2018, 2:38 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG09b58af83d44: bookmarks: test for exchanging long bookmark names (issue5165)
Summary

As far as I can tell a test for a long bookmark name never actually
got added when this was fixed. Let's document that a 300 byte bookmark
is something we're supporting (this patch started out life over a year
ago as a way for me to validate the problem, and I recently found it.)

I think the nonzero exits from the push operations are only because no
new changesets get exchanged. Please correct me if I'm wrong on that. :)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Mar 8 2018, 2:38 PM
Closed by commit rHG09b58af83d44: bookmarks: test for exchanging long bookmark names (issue5165) (authored by durin42). · Explain WhyMar 9 2018, 8:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-bookmarks-pushpull.t (28 lines)

Diff 6762

tests/test-bookmarks-pushpull.t

exporting bookmark @ exporting bookmark @
$ hg push -B @ ../unchanged-b $ hg push -B @ ../unchanged-b
pushing to ../unchanged-b pushing to ../unchanged-b
searching for changes searching for changes
no changes found no changes found
[1] [1]
Pushing a really long bookmark should work fine (issue5165)
===============================================
#if b2-binary
>>> open('longname', 'w').write('wat' * 100)
$ hg book `cat longname`
$ hg push -B `cat longname` ../unchanged-b
pushing to ../unchanged-b
searching for changes
no changes found
exporting bookmark (wat){100} (re)
[1]
$ hg -R ../unchanged-b book --delete `cat longname`
Test again but forcing bundle2 exchange to make sure that doesn't regress.
$ hg push -B `cat longname` ../unchanged-b --config devel.legacy.exchange=bundle1
pushing to ../unchanged-b
searching for changes
no changes found
exporting bookmark (wat){100} (re)
[1]
$ hg -R ../unchanged-b book --delete `cat longname`
$ hg book --delete `cat longname`
$ hg co @
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
(activating bookmark @)
#endif
Check hook preventing push (issue4455) Check hook preventing push (issue4455)
====================================== ======================================
$ hg bookmarks $ hg bookmarks
* @ 0:55482a6fb4b1 * @ 0:55482a6fb4b1
$ hg log -G $ hg log -G
@ 0:55482a6fb4b1 initial @ 0:55482a6fb4b1 initial