This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3192

addbranchrevs: no longer accept revset as "revs" (API)
ClosedPublic

Authored by martinvonz on Apr 8 2018, 12:48 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG7c848ab13eff: addbranchrevs: no longer accept revset as "revs" (API)
Summary

The only caller was removed in 0b4692b9646d (bundle: avoid
repo.lookup() for converting revnum to nodeid, 2018-04-02).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 8 2018, 12:48 PM
Closed by commit rHG7c848ab13eff: addbranchrevs: no longer accept revset as "revs" (API) (authored by martinvonz). · Explain WhyApr 9 2018, 10:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hg.py (4 lines)

Diff 7892

mercurial/hg.py

path = util.expandpath(util.urllocalpath(path)) path = util.expandpath(util.urllocalpath(path))
return (os.path.isfile(path) and bundlerepo or localrepo) return (os.path.isfile(path) and bundlerepo or localrepo)
def addbranchrevs(lrepo, other, branches, revs): def addbranchrevs(lrepo, other, branches, revs):
peer = other.peer() # a courtesy to callers using a localrepo for other peer = other.peer() # a courtesy to callers using a localrepo for other
hashbranch, branches = branches hashbranch, branches = branches
if not hashbranch and not branches: if not hashbranch and not branches:
x = revs or None x = revs or None
if util.safehasattr(revs, 'first'): if revs:
y = revs.first()
elif revs:
y = revs[0] y = revs[0]
else: else:
y = None y = None
return x, y return x, y
if revs: if revs:
revs = list(revs) revs = list(revs)
else: else:
revs = [] revs = []