This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3372

keepalive: add ** overlooked in 83250442dc81
ClosedPublic

Authored by durin42 on Apr 14 2018, 10:43 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGe266e75d77dc: keepalive: add ** overlooked in 83250442dc81
rHG2177b499db6b: keepalive: add ** overlooked in 83250442dc81
Summary

Caught by Yuya in D3326.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Apr 14 2018, 10:43 AM
Closed by commit rHG2177b499db6b: keepalive: add ** overlooked in 83250442dc81 (authored by durin42). · Explain WhyApr 14 2018, 6:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/keepalive.py (4 lines)

Diff 8287

mercurial/keepalive.py

for n in (r'host', r'accept-encoding'): for n in (r'host', r'accept-encoding'):
if n in headers: if n in headers:
skipheaders[r'skip_' + n.replace(r'-', r'_')] = 1 skipheaders[r'skip_' + n.replace(r'-', r'_')] = 1
try: try:
if urllibcompat.hasdata(req): if urllibcompat.hasdata(req):
data = urllibcompat.getdata(req) data = urllibcompat.getdata(req)
h.putrequest( h.putrequest(
req.get_method(), urllibcompat.getselector(req), req.get_method(), urllibcompat.getselector(req),
skipheaders) **skipheaders)
if r'content-type' not in headers: if r'content-type' not in headers:
h.putheader(r'Content-type', h.putheader(r'Content-type',
r'application/x-www-form-urlencoded') r'application/x-www-form-urlencoded')
if r'content-length' not in headers: if r'content-length' not in headers:
h.putheader(r'Content-length', r'%d' % len(data)) h.putheader(r'Content-length', r'%d' % len(data))
else: else:
h.putrequest( h.putrequest(
req.get_method(), urllibcompat.getselector(req), req.get_method(), urllibcompat.getselector(req),
skipheaders) **skipheaders)
except socket.error as err: except socket.error as err:
raise urlerr.urlerror(err) raise urlerr.urlerror(err)
for k, v in headers.items(): for k, v in headers.items():
h.putheader(k, v) h.putheader(k, v)
h.endheaders() h.endheaders()
if urllibcompat.hasdata(req): if urllibcompat.hasdata(req):
h.send(data) h.send(data)