This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3404

scripts: remove code for special handling of generaldelta; r?sheehan
AbandonedPublic

Authored by indygreg on Apr 17 2018, 5:58 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

generaldelta has been the default for new Mercurial repos for
probably 2 years now. Setting format.generaldelta=true had no effect
because it was redundant with the default. So stop doing that.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 17 2018, 5:58 PM
indygreg abandoned this revision.Apr 17 2018, 5:59 PM

Sent this to the wrong Phabricator instance :)

Revision Contents
Changeset List

Diff 8378

scripts/sync-hg-repos-from-manifest

def clone_or_pull(rel, path, requires, url, user, group): def clone_or_pull(rel, path, requires, url, user, group):
is_clone = False is_clone = False
try: try:
if not os.path.exists(path): if not os.path.exists(path):
is_clone = True is_clone = True
args = [HG, 'init', path] args = [HG, 'init', path]
if 'generaldelta' in requires:
args.extend(['--config', 'format.generaldelta=true'])
print('creating empty repo: %s' % path) print('creating empty repo: %s' % path)
subprocess.check_output(args, cwd='/', stderr=subprocess.STDOUT) subprocess.check_output(args, cwd='/', stderr=subprocess.STDOUT)
# Disable clonebundles to ensure the client doesn't use stream clone and # Disable clonebundles to ensure the client doesn't use stream clone and
# recreates the store and revlogs from scratch. # recreates the store and revlogs from scratch.
args = [HG, '--config', 'ui.clonebundles=false', '-R', path, 'pull', url] args = [HG, '--config', 'ui.clonebundles=false', '-R', path, 'pull', url]
subprocess.check_output(args, cwd='/', stderr=subprocess.STDOUT) subprocess.check_output(args, cwd='/', stderr=subprocess.STDOUT)