This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3644

state: raise CorruptedState error isntead of ProgrammingError
ClosedPublic

Authored by pulkit on May 22 2018, 5:52 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGdce718404ce6: state: raise CorruptedState error isntead of ProgrammingError
Summary

There are old state files which don't have a version number in top of them and
hence we have to read them to check whether they are good or not.
ProgrammingError is not apt for this case. Thanks to Yuya for suggesting
CorruptedState error.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.May 22 2018, 5:52 PM
Closed by commit rHGdce718404ce6: state: raise CorruptedState error isntead of ProgrammingError (authored by pulkit). · Explain WhyMay 23 2018, 8:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/state.py (4 lines)

Diff 8879

mercurial/state.py

def _read(self): def _read(self):
"""reads the state file and returns a dictionary which contain """reads the state file and returns a dictionary which contain
data in the same format as it was before storing""" data in the same format as it was before storing"""
with self._repo.vfs(self.fname, 'rb') as fp: with self._repo.vfs(self.fname, 'rb') as fp:
try: try:
int(fp.readline()) int(fp.readline())
except ValueError: except ValueError:
raise error.ProgrammingError("unknown version of state file" raise error.CorruptedState("unknown version of state file"
" found") " found")
return cbor.load(fp) return cbor.load(fp)
def delete(self): def delete(self):
"""drop the state file if exists""" """drop the state file if exists"""
util.unlinkpath(self._repo.vfs.join(self.fname), ignoremissing=True) util.unlinkpath(self._repo.vfs.join(self.fname), ignoremissing=True)
def exists(self): def exists(self):
"""check whether the state file exists or not""" """check whether the state file exists or not"""
return self._repo.vfs.exists(self.fname) return self._repo.vfs.exists(self.fname)