This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3843

tests: fix up some lax escaping in test-template-basic.t
ClosedPublic

Authored by durin42 on Jun 26 2018, 1:04 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb4cfd803b3f2: tests: fix up some lax escaping in test-template-basic.t
Summary

These misfired escapes turn into hard errors in Python 3.7, and I'd
really rather we not work around it. We should *probably* try and find
a way to proactively warn users about invalid escape sequences.

There's one more failure of this type in this file on Python 3.7, but
I can't figure out the issue. It'll need to be corrected in a
follow-up.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jun 26 2018, 1:04 PM
Closed by commit rHGb4cfd803b3f2: tests: fix up some lax escaping in test-template-basic.t (authored by durin42). · Explain WhyJun 27 2018, 9:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-template-basic.t (4 lines)

Diff 9322

tests/test-template-basic.t

o perso o perso
$ hg log -R a -r 2 --template '{strip(r"no perso\x6e", r"\x6e")}\n' $ hg log -R a -r 2 --template '{strip(r"no perso\x6e", r"\x6e")}\n'
no perso no perso
$ hg log -R a -r 2 --template '{sub("\\x6e", "\x2d", desc)}\n' $ hg log -R a -r 2 --template '{sub("\\x6e", "\x2d", desc)}\n'
-o perso- -o perso-
$ hg log -R a -r 2 --template '{sub(r"\\x6e", "-", desc)}\n' $ hg log -R a -r 2 --template '{sub(r"\\x6e", "-", desc)}\n'
no person no person
$ hg log -R a -r 2 --template '{sub("n", r"\x2d", desc)}\n' $ hg log -R a -r 2 --template '{sub("n", r"\\x2d", desc)}\n'
\x2do perso\x2d \x2do perso\x2d
$ hg log -R a -r 2 --template '{sub("n", "\x2d", "no perso\x6e")}\n' $ hg log -R a -r 2 --template '{sub("n", "\x2d", "no perso\x6e")}\n'
-o perso- -o perso-
$ hg log -R a -r 2 --template '{sub("n", r"\x2d", r"no perso\x6e")}\n' $ hg log -R a -r 2 --template '{sub("n", r"\\x2d", r"no perso\x6e")}\n'
\x2do perso\x6e \x2do perso\x6e
$ hg log -R a -r 8 --template '{files % "{file}\n"}' $ hg log -R a -r 8 --template '{files % "{file}\n"}'
fourth fourth
second second
third third
Test string escaping in nested expression: Test string escaping in nested expression: