This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3878

tests: remove some redundant code in run-tests
ClosedPublic

Authored by martinvonz on Jul 3 2018, 7:42 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG174484b2528d: tests: remove some redundant code in run-tests
Summary

These two lines also happen below if "r" is truthy, which it is in
this case since it's equal to "retry".

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Jul 3 2018, 7:42 PM
martinvonz updated this revision to Diff 9425.Jul 3 2018, 7:50 PM
Closed by commit rHG174484b2528d: tests: remove some redundant code in run-tests (authored by martinvonz). · Explain WhyJul 5 2018, 8:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (2 lines)

Diff 9425

tests/run-tests.py

r = self.linematch(el, lout) r = self.linematch(el, lout)
if isinstance(r, str): if isinstance(r, str):
if r == '-glob': if r == '-glob':
lout = ''.join(el.rsplit(' (glob)', 1)) lout = ''.join(el.rsplit(' (glob)', 1))
r = '' # Warn only this line. r = '' # Warn only this line.
elif r == "retry": elif r == "retry":
postout.append(b' ' + el) postout.append(b' ' + el)
els.pop(i)
break
else: else:
log('\ninfo, unknown linematch result: %r\n' % r) log('\ninfo, unknown linematch result: %r\n' % r)
r = False r = False
if r: if r:
els.pop(i) els.pop(i)
break break
if el: if el:
if el.endswith(b" (?)\n"): if el.endswith(b" (?)\n"):