This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3895

context: raise ProgrammingError on repo['my-tag']
ClosedPublic

Authored by martinvonz on Jul 6 2018, 8:03 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG91618801d5c3: context: raise ProgrammingError on repo['my-tag']
Summary

We had an internal extension that I had failed to migrate off of the
deprecated API and its "'my-tag' in repo" check just started returning
False. It took a while to figure out that that was what was
happening. This patch would have helped.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jul 6 2018, 8:03 PM
Closed by commit rHG91618801d5c3: context: raise ProgrammingError on repo['my-tag'] (authored by martinvonz). · Explain WhyJul 6 2018, 10:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (4 lines)

Diff 9467

mercurial/context.py

try: try:
self._node = bin(changeid) self._node = bin(changeid)
self._rev = repo.changelog.rev(self._node) self._rev = repo.changelog.rev(self._node)
return return
except error.FilteredLookupError: except error.FilteredLookupError:
raise raise
except (TypeError, LookupError): except (TypeError, LookupError):
pass pass
else:
raise error.ProgrammingError(
"unsupported changeid '%s' of type %s" %
(changeid, type(changeid)))
# lookup failed # lookup failed
except (error.FilteredIndexError, error.FilteredLookupError): except (error.FilteredIndexError, error.FilteredLookupError):
raise error.FilteredRepoLookupError(_("filtered revision '%s'") raise error.FilteredRepoLookupError(_("filtered revision '%s'")
% pycompat.bytestr(changeid)) % pycompat.bytestr(changeid))
except error.FilteredRepoLookupError: except error.FilteredRepoLookupError:
raise raise
except IndexError: except IndexError: