This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4122

localrepo: better error when a repo exists but we lack permissions
ClosedPublic

Authored by valentin.gatienbaron on Aug 5 2018, 11:49 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGac0a87160012: localrepo: better error when a repo exists but we lack permissions
Summary

Claiming "repository foo not found" when the repository does exist
causes confusion regularly ("where is the typo?").

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Closed by commit rHGac0a87160012: localrepo: better error when a repo exists but we lack permissions (authored by valentin.gatienbaron). · Explain WhyAug 9 2018, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (5 lines)
Mtests/test-clone.t (4 lines)

Diff 10150

mercurial/localrepo.py

# create an invalid changelog # create an invalid changelog
self.vfs.append( self.vfs.append(
"00changelog.i", "00changelog.i",
'\0\0\0\2' # represents revlogv2 '\0\0\0\2' # represents revlogv2
' dummy changelog to prevent using the old repo layout' ' dummy changelog to prevent using the old repo layout'
) )
else: else:
try:
self.vfs.stat()
except OSError as inst:
if inst.errno != errno.ENOENT:
raise
raise error.RepoError(_("repository %s not found") % path) raise error.RepoError(_("repository %s not found") % path)
elif create: elif create:
raise error.RepoError(_("repository %s already exists") % path) raise error.RepoError(_("repository %s already exists") % path)
else: else:
try: try:
self.requirements = scmutil.readrequires( self.requirements = scmutil.readrequires(
self.vfs, self.supported) self.vfs, self.supported)
except IOError as inst: except IOError as inst:

tests/test-clone.t

#if unix-permissions no-root #if unix-permissions no-root
Inaccessible source Inaccessible source
$ mkdir a $ mkdir a
$ chmod 000 a $ chmod 000 a
$ hg clone a b $ hg clone a b
abort: repository a not found! abort: Permission denied: '$TESTTMP/fail/a/.hg'
[255] [255]
Inaccessible destination Inaccessible destination
$ hg init b $ hg init b
$ cd b $ cd b
$ hg clone . ../a $ hg clone . ../a
abort: Permission denied: '../a' abort: Permission denied: '../a'
[255] [255]
$ cd .. $ cd ..
$ chmod 700 a $ chmod 700 a
$ rm -r a b $ rm -r a b
#endif #endif
#if fifo #if fifo
Source of wrong type Source of wrong type
$ mkfifo a $ mkfifo a
$ hg clone a b $ hg clone a b
abort: repository a not found! abort: $ENOTDIR$: '$TESTTMP/fail/a/.hg'
[255] [255]
$ rm a $ rm a
#endif #endif
Default destination, same directory Default destination, same directory
$ hg init q $ hg init q