This is an archive of the discontinued Mercurial Phabricator instance.

shortest: don't include nullid in disambigution revset
ClosedPublic

Authored by martinvonz on Aug 9 2018, 3:27 AM.

Details

Summary

As noted by Yuya in the review of D4118, the fact that the nodetree
always contains the nullid is not what we want for the disambiguation
case. It's not what the pure version of the code does.

Note that the updated test also passes before this patch, but it
wouldn't have passed in native-code mode once we start using the
nodetree for disambiguating nodeid prefixes.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.