( )⚙ D4347 demandimport: instrument python 2 code with trace events

This is an archive of the discontinued Mercurial Phabricator instance.

demandimport: instrument python 2 code with trace events
ClosedPublic

Authored by durin42 on Aug 21 2018, 5:39 PM.

Details

Summary

This causes the evaluation of an import in Python 3 to emit some trace
data. There's some interesting wrinkles in here, like the fact that
before we even hit dispatch we've demand-imported sys several times,
despite the fact that sys was already fully loaded as one of the
first few statements in the hg script. I don't think that's actually
costing us a ton of performance, but it's probably something we should
investigate fixing some day.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Aug 21 2018, 5:39 PM
This revision was automatically updated to reflect the committed changes.