This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4431

py3: don't use dict.iterkeys() in hgext/fastannotate/context.py
ClosedPublic

Authored by pulkit on Aug 31 2018, 4:46 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG1099d9bbdf9a: py3: don't use dict.iterkeys() in hgext/fastannotate/context.py
Summary

dict.iterkeys() is not present on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Aug 31 2018, 4:46 PM
Closed by commit rHG1099d9bbdf9a: py3: don't use dict.iterkeys() in hgext/fastannotate/context.py (authored by pulkit). · Explain WhyAug 31 2018, 8:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fastannotate/context.py (2 lines)

Diff 10701

hgext/fastannotate/context.py

.replace('.hg/', '.hg.hg/') .replace('.hg/', '.hg.hg/')
.replace('.l/', '.l.hg/') .replace('.l/', '.l.hg/')
.replace('.m/', '.m.hg/') .replace('.m/', '.m.hg/')
.replace('.lock/', '.lock.hg/')) .replace('.lock/', '.lock.hg/'))
def hashdiffopts(diffopts): def hashdiffopts(diffopts):
diffoptstr = str(sorted( diffoptstr = str(sorted(
(k, getattr(diffopts, k)) (k, getattr(diffopts, k))
for k in mdiff.diffopts.defaults.iterkeys() for k in mdiff.diffopts.defaults
)) ))
return hashlib.sha1(diffoptstr).hexdigest()[:6] return hashlib.sha1(diffoptstr).hexdigest()[:6]
_defaultdiffopthash = hashdiffopts(mdiff.defaultopts) _defaultdiffopthash = hashdiffopts(mdiff.defaultopts)
class annotateopts(object): class annotateopts(object):
"""like mercurial.mdiff.diffopts, but is for annotate """like mercurial.mdiff.diffopts, but is for annotate