This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4445

tracing: ignore any IOErrors when writing to pipe
ClosedPublic

Authored by durin42 on Sep 1 2018, 11:33 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG452790284a15: tracing: ignore any IOErrors when writing to pipe
Summary

When the pager forks off the main process, we can end up with the pipe
closed prematurely. Rather than break hg entirely when that happens
and tracing is active, just let lingering events disappear as needed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 1 2018, 11:33 AM
Closed by commit rHG452790284a15: tracing: ignore any IOErrors when writing to pipe (authored by durin42). · Explain WhySep 2 2018, 1:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgdemandimport/tracing.py (14 lines)

Diff 10712

hgdemandimport/tracing.py

_checked = True _checked = True
if 'HGCATAPULTSERVERPIPE' not in os.environ: if 'HGCATAPULTSERVERPIPE' not in os.environ:
yield yield
return return
_pipe = open(os.environ['HGCATAPULTSERVERPIPE'], 'w', 1) _pipe = open(os.environ['HGCATAPULTSERVERPIPE'], 'w', 1)
_session = os.environ.get('HGCATAPULTSESSION', 'none') _session = os.environ.get('HGCATAPULTSESSION', 'none')
whence = whencefmt % whenceargs whence = whencefmt % whenceargs
try: try:
# Both writes to the pipe are wrapped in try/except to ignore
# errors, as we can see mysterious errors in here if the pager
# is active. Presumably other conditions could trigger
# problems too.
try:
_pipe.write('START %s %s\n' % (_session, whence)) _pipe.write('START %s %s\n' % (_session, whence))
except IOError:
pass
yield yield
finally: finally:
try:
_pipe.write('END %s %s\n' % (_session, whence)) _pipe.write('END %s %s\n' % (_session, whence))
except IOError:
pass