( )⚙ D4696 py3: use '%d' for integers instead of '%s'

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4696

py3: use '%d' for integers instead of '%s'
ClosedPublic

Authored by pulkit on Sep 23 2018, 9:09 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG69defbb83be7: py3: use '%d' for integers instead of '%s'
Summary

Python 3 does not allow using "%s" for integers.

This makes the test works on Python 3. The test still does not pass because
there is a deprecation warning.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Sep 23 2018, 9:09 PM
Closed by commit rHG69defbb83be7: py3: use '%d' for integers instead of '%s' (authored by pulkit). · Explain WhySep 24 2018, 1:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-bdiff.py (4 lines)

Diff 11298

tests/test-bdiff.py

] ]
for a, b, allws in cases: for a, b, allws in cases:
c = mdiff.fixws(a, allws) c = mdiff.fixws(a, allws)
self.assertEqual( self.assertEqual(
c, b, 'fixws(%r) want %r got %r (allws=%r)' % (a, b, c, allws)) c, b, 'fixws(%r) want %r got %r (allws=%r)' % (a, b, c, allws))
def test_nice_diff_for_trivial_change(self): def test_nice_diff_for_trivial_change(self):
self.assertEqual(self.showdiff( self.assertEqual(self.showdiff(
b''.join(b'<%s\n-\n' % i for i in range(5)), b''.join(b'<%d\n-\n' % i for i in range(5)),
b''.join(b'>%s\n-\n' % i for i in range(5))), b''.join(b'>%d\n-\n' % i for i in range(5))),
[diffreplace(0, 3, b'<0\n', b'>0\n'), [diffreplace(0, 3, b'<0\n', b'>0\n'),
b'-\n', b'-\n',
diffreplace(5, 8, b'<1\n', b'>1\n'), diffreplace(5, 8, b'<1\n', b'>1\n'),
b'-\n', b'-\n',
diffreplace(10, 13, b'<2\n', b'>2\n'), diffreplace(10, 13, b'<2\n', b'>2\n'),
b'-\n', b'-\n',
diffreplace(15, 18, b'<3\n', b'>3\n'), diffreplace(15, 18, b'<3\n', b'>3\n'),
b'-\n', b'-\n',