( )⚙ D4833 py3: use system strings in HTTP server code

This is an archive of the discontinued Mercurial Phabricator instance.

py3: use system strings in HTTP server code
ClosedPublic

Authored by indygreg on Oct 2 2018, 2:17 AM.

Details

Summary

Previously the source transformer was converting some string literals
to bytes and we were comparing a system native string to bytes
and this was leading to sending the wrong HTTP response headers on
Python 3.

After this change, we now properly send Transfer-Encoding and
Connection response headers on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 2 2018, 2:17 AM
This revision was automatically updated to reflect the committed changes.