( )⚙ D4835 py3: use system strings for HTTP response header comparison

This is an archive of the discontinued Mercurial Phabricator instance.

py3: use system strings for HTTP response header comparison
ClosedPublic

Authored by indygreg on Oct 2 2018, 2:17 AM.

Details

Summary

res.headers is holding system strings. Attempting to compare against
bytes always fails and we fail to print decoded CBOR responses on
Python 3.

After this change, various test-wireproto* tests are now properly
printing CBOR response objects.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 2 2018, 2:17 AM
This revision was automatically updated to reflect the committed changes.