This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4910

tests: do not change sys.path, it can break loading cext.parsers
ClosedPublic

Authored by joerg.sonnenberger on Oct 8 2018, 3:53 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG8a08aefa9273: tests: do not change sys.path, it can break loading cext.parsers
Summary

When running this tests with run-tests, the prefix would resolve
mercurial.cext to the source tree and the attempt to load
mercurial.cext.parsers would therefore fail since it doesn't exist in
it. With the regular search path from run-tests, it is picked up from
the temporary prefix correctly.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Closed by commit rHG8a08aefa9273: tests: do not change sys.path, it can break loading cext.parsers (authored by joerg.sonnenberger). · Explain WhyOct 9 2018, 8:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-lfs-pointer.py (6 lines)
Mtests/test-minifileset.py (6 lines)

Diff 11768

tests/test-lfs-pointer.py

from __future__ import absolute_import, print_function from __future__ import absolute_import, print_function
import os
import sys
# make it runnable using python directly without run-tests.py
sys.path[0:0] = [os.path.join(os.path.dirname(__file__), '..')]
# Import something from Mercurial, so the module loader gets initialized. # Import something from Mercurial, so the module loader gets initialized.
from mercurial import pycompat from mercurial import pycompat
del pycompat # unused for now del pycompat # unused for now
from hgext.lfs import pointer from hgext.lfs import pointer
def tryparse(text): def tryparse(text):
r = {} r = {}

tests/test-minifileset.py

from __future__ import absolute_import from __future__ import absolute_import
from __future__ import print_function from __future__ import print_function
import os
import sys
# make it runnable directly without run-tests.py
sys.path[0:0] = [os.path.join(os.path.dirname(__file__), '..')]
from mercurial import minifileset from mercurial import minifileset
def check(text, truecases, falsecases): def check(text, truecases, falsecases):
f = minifileset.compile(text) f = minifileset.compile(text)
for args in truecases: for args in truecases:
if not f(*args): if not f(*args):
print('unexpected: %r should include %r' % (text, args)) print('unexpected: %r should include %r' % (text, args))
for args in falsecases: for args in falsecases: