( )⚙ D4996 revlog: update pure nodecache start lookup offset on insertion

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4996

revlog: update pure nodecache start lookup offset on insertion
ClosedPublic

Authored by indygreg on Oct 12 2018, 10:19 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGba70e3acf58a: revlog: update pure nodecache start lookup offset on insertion
Summary

test-storage.py is failing in pure builds because the population of the node
cache isn't accounting for the new starting offset after a revlog insertion.

This commit updates the node cache start offset to account for insertions.

I'm not 100% convinced this is the ideal solution. But it works and seems
correct.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 12 2018, 10:19 AM
Closed by commit rHGba70e3acf58a: revlog: update pure nodecache start lookup offset on insertion (authored by indygreg). · Explain WhyOct 12 2018, 11:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (5 lines)

Diff 11890

mercurial/revlog.py

deltainfo = deltacomputer.finddeltainfo(revinfo, fh) deltainfo = deltacomputer.finddeltainfo(revinfo, fh)
e = (offset_type(offset, flags), deltainfo.deltalen, textlen, e = (offset_type(offset, flags), deltainfo.deltalen, textlen,
deltainfo.base, link, p1r, p2r, node) deltainfo.base, link, p1r, p2r, node)
self.index.append(e) self.index.append(e)
self.nodemap[node] = curr self.nodemap[node] = curr
# Reset the pure node cache start lookup offset to account for new
# revision.
if self._nodepos is not None:
self._nodepos = curr
entry = self._io.packentry(e, self.node, self.version, curr) entry = self._io.packentry(e, self.node, self.version, curr)
self._writeentry(transaction, ifh, dfh, entry, deltainfo.data, self._writeentry(transaction, ifh, dfh, entry, deltainfo.data,
link, offset) link, offset)
rawtext = btext[0] rawtext = btext[0]
if alwayscache and rawtext is None: if alwayscache and rawtext is None:
rawtext = deltacomputer.buildtext(revinfo, fh) rawtext = deltacomputer.buildtext(revinfo, fh)