This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5110

tests: test-parseindex.t requires no-pure
AbandonedPublic

Authored by adgar on Oct 15 2018, 10:25 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

Custom python code in test-parseindex.t calls reachableroots2 which is only
available in the C revlog index implementation. Marking it #require no-pure
ensure it will not run for --pure test runs.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

adgar created this revision.Oct 15 2018, 10:25 AM
yuja added a subscriber: yuja.Oct 16 2018, 3:21 AM
Custom python code in test-parseindex.t calls reachableroots2 which is only
available in the C revlog index implementation. Marking it #require no-pure
ensure it will not run for --pure test runs.

It's surrounded with #if no-pure. Did you experience any test failure?

adgar added a comment.Oct 16 2018, 10:55 PM

I had been seeing test failures, but I suspect it is due to a misconfigured build and not an actual bug. Withdrawing this change.

adgar abandoned this revision.Oct 16 2018, 10:55 PM

Revision Contents
Changeset List

PathPackages
Mtests/test-parseindex.t (2 lines)

Diff 12150

tests/test-parseindex.t

#require no-pure # pure revlog index does not have reachableroots2 function
revlog.parseindex must be able to parse the index file even if revlog.parseindex must be able to parse the index file even if
an index entry is split between two 64k blocks. The ideal test an index entry is split between two 64k blocks. The ideal test
would be to create an index file with inline data where would be to create an index file with inline data where
64k < size < 64k + 64 (64k is the size of the read buffer, 64 is 64k < size < 64k + 64 (64k is the size of the read buffer, 64 is
the size of an index entry) and with an index entry starting right the size of an index entry) and with an index entry starting right
before the 64k block boundary, and try to read it. before the 64k block boundary, and try to read it.
We approximate that by reducing the read buffer to 1 byte. We approximate that by reducing the read buffer to 1 byte.