This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5152

debugcommands: avoid stack trace from debugindexstats in pure mode
ClosedPublic

Authored by martinvonz on Oct 18 2018, 1:14 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG4f37af86d5d5: debugcommands: avoid stack trace from debugindexstats in pure mode
Summary

This has been broken since I added it in d71e0ba34d9b (debugcommands:
add a debugindexstats command, 2018-08-08). This patch also fixes the
test.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 18 2018, 1:14 PM
Closed by commit rHG4f37af86d5d5: debugcommands: avoid stack trace from debugindexstats in pure mode (authored by martinvonz). · Explain WhyOct 18 2018, 1:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12250

mercurial/debugcommands.py

if pp[1] != nullid: if pp[1] != nullid:
ui.write("\t%d -> %d\n" % (r.rev(pp[1]), i)) ui.write("\t%d -> %d\n" % (r.rev(pp[1]), i))
ui.write("}\n") ui.write("}\n")
@command('debugindexstats', []) @command('debugindexstats', [])
def debugindexstats(ui, repo): def debugindexstats(ui, repo):
"""show stats related to the changelog index""" """show stats related to the changelog index"""
repo.changelog.shortest(nullid, 1) repo.changelog.shortest(nullid, 1)
for k, v in sorted(repo.changelog.index.stats().items()): index = repo.changelog.index
if not util.safehasattr(index, 'stats'):
raise error.Abort(_('debugindexstats only works with native code'))
for k, v in sorted(index.stats().items()):
ui.write('%s: %s\n' % (k, v)) ui.write('%s: %s\n' % (k, v))
@command('debuginstall', [] + cmdutil.formatteropts, '', norepo=True) @command('debuginstall', [] + cmdutil.formatteropts, '', norepo=True)
def debuginstall(ui, **opts): def debuginstall(ui, **opts):
'''test Mercurial installation '''test Mercurial installation
Returns 0 on success. Returns 0 on success.
''' '''

tests/test-debugcommands.t

rev linkrev nodeid p1 p2 rev linkrev nodeid p1 p2
0 0 b789fdd96dc2 000000000000 000000000000 0 0 b789fdd96dc2 000000000000 000000000000
$ hg debugindex --debug a $ hg debugindex --debug a
rev linkrev nodeid p1 p2 rev linkrev nodeid p1 p2
0 0 b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3 0000000000000000000000000000000000000000 0000000000000000000000000000000000000000 0 0 b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3 0000000000000000000000000000000000000000 0000000000000000000000000000000000000000
debugdelta chain basic output debugdelta chain basic output
#if reporevlogstore #if reporevlogstore pure
$ hg debugindexstats
abort: debugindexstats only works with native code
[255]
#endif
#if reporevlogstore no-pure
$ hg debugindexstats $ hg debugindexstats
node trie capacity: 4 node trie capacity: 4
node trie count: 2 node trie count: 2
node trie depth: 1 node trie depth: 1
node trie last rev scanned: -1 node trie last rev scanned: -1
node trie lookups: 4 node trie lookups: 4
node trie misses: 1 node trie misses: 1
node trie splits: 1 node trie splits: 1
revs in memory: 3 revs in memory: 3
#endif
#if reporevlogstore no-pure
$ hg debugdeltachain -m $ hg debugdeltachain -m
rev chain# chainlen prev delta size rawsize chainsize ratio lindist extradist extraratio rev chain# chainlen prev delta size rawsize chainsize ratio lindist extradist extraratio
0 1 1 -1 base 44 43 44 1.02326 44 0 0.00000 0 1 1 -1 base 44 43 44 1.02326 44 0 0.00000
1 2 1 -1 base 0 0 0 0.00000 0 0 0.00000 1 2 1 -1 base 0 0 0 0.00000 0 0 0.00000
2 3 1 -1 base 44 43 44 1.02326 44 0 0.00000 2 3 1 -1 base 44 43 44 1.02326 44 0 0.00000
$ hg debugdeltachain -m -T '{rev} {chainid} {chainlen}\n' $ hg debugdeltachain -m -T '{rev} {chainid} {chainlen}\n'
0 1 1 0 1 1