This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5228

perf: fix perfrevlogrevisions --reverse
ClosedPublic

Authored by lothiraldan on Nov 6 2018, 3:33 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGcbd251d479bb: perf: fix perfrevlogrevisions --reverse
Summary

Currently, 'endrev' equals len(revlog), a revision that does not exist.

When asking for the reverse order, the arguments passed to xrange are
xrange(len(revlog), startrev) which then crash.

We need to offset 'endrev' by one so we don't crash anymore. Also, we offset
'startrev' to ensure we get the same number of revisions with and without the
--reverse option.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Nov 6 2018, 3:33 AM
Closed by commit rHGcbd251d479bb: perf: fix perfrevlogrevisions --reverse (authored by lothiraldan). · Explain WhyNov 6 2018, 7:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (2 lines)

Diff 12450

contrib/perf.py

def d(): def d():
rl.clearcaches() rl.clearcaches()
beginrev = startrev beginrev = startrev
endrev = rllen endrev = rllen
dist = opts[b'dist'] dist = opts[b'dist']
if reverse: if reverse:
beginrev, endrev = endrev, beginrev beginrev, endrev = endrev - 1, beginrev - 1
dist = -1 * dist dist = -1 * dist
for x in _xrange(beginrev, endrev, dist): for x in _xrange(beginrev, endrev, dist):
# Old revisions don't support passing int. # Old revisions don't support passing int.
n = rl.node(x) n = rl.node(x)
rl.revision(n) rl.revision(n)
timer, fm = gettimer(ui, opts) timer, fm = gettimer(ui, opts)