This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5239

tests: replace `tac` reimplementation by `sort -r`
ClosedPublic

Authored by martinvonz on Nov 7 2018, 1:30 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG0df4d93fdc27: tests: replace `tac` reimplementation by `sort -r`
Summary

sort -r is better code "formatter" than tac since it's
stable. It's also portable so we don't need to reimplement it in
Python.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Nov 7 2018, 1:30 PM
Closed by commit rHG0df4d93fdc27: tests: replace `tac` reimplementation by `sort -r` (authored by martinvonz). · Explain WhyNov 7 2018, 2:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-fix.t (7 lines)

Diff 12470

tests/test-fix.t

A script that implements uppercasing of specific lines in a file. This A script that implements uppercasing of specific lines in a file. This
approximates the behavior of code formatters well enough for our tests. approximates the behavior of code formatters well enough for our tests.
$ TAC="$TESTTMP/tac.py"
$ cat > $TAC <<EOF
> import sys
> print('\n'.join(sys.stdin.read().splitlines()[::-1]))
> EOF
$ UPPERCASEPY="$TESTTMP/uppercase.py" $ UPPERCASEPY="$TESTTMP/uppercase.py"
$ cat > $UPPERCASEPY <<EOF $ cat > $UPPERCASEPY <<EOF
> import sys > import sys
> from mercurial.utils.procutil import setbinary > from mercurial.utils.procutil import setbinary
> setbinary(sys.stdin) > setbinary(sys.stdin)
> setbinary(sys.stdout) > setbinary(sys.stdout)
> lines = set() > lines = set()
> for arg in sys.argv[1:]: > for arg in sys.argv[1:]:
$ hg init filesetispattern $ hg init filesetispattern
$ cd filesetispattern $ cd filesetispattern
$ printf "foo\n" > foo.whole $ printf "foo\n" > foo.whole
$ printf "first\nsecond\n" > bar.txt $ printf "first\nsecond\n" > bar.txt
$ hg add -q $ hg add -q
$ hg fix -w --config fix.sometool:fileset=bar.txt \ $ hg fix -w --config fix.sometool:fileset=bar.txt \
> --config fix.sometool:command="$PYTHON $TAC" > --config fix.sometool:command="sort -r"
the fix.tool:fileset config name is deprecated; please rename it to fix.tool:pattern the fix.tool:fileset config name is deprecated; please rename it to fix.tool:pattern
$ cat foo.whole $ cat foo.whole
FOO FOO
$ cat bar.txt $ cat bar.txt
second second
first first
$ cd .. $ cd ..