( )⚙ D5253 remotefilelog: avoid accessing repo instance after dispatch

This is an archive of the discontinued Mercurial Phabricator instance.

remotefilelog: avoid accessing repo instance after dispatch
ClosedPublic

Authored by martinvonz on Nov 9 2018, 2:28 PM.

Details

Summary

Upstream commit c5e6c1ba1c79 (hg: don't reuse repo instance after
unshare(), 2018-09-12) poisoned the repo instance after
unshare(). That made hg unshare fail with remotefilelog because we
tried to close the fileserverclient after dispatch by accessing it via
the repo. This patch fixes that by storing the reference to the
fileserverclient at the beginning of dispatch.

An analogous patch was sent for remotefilelog version in FB's
hg-experimental as D5246.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Nov 9 2018, 2:28 PM
martinvonz updated this revision to Diff 12496.Nov 9 2018, 3:31 PM
This revision was automatically updated to reflect the committed changes.