This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5274

requires: use atomictemp=True when writing .hg/requires
ClosedPublic

Authored by martinvonz on Nov 14 2018, 3:05 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGacd17caa699a: requires: use atomictemp=True when writing .hg/requires
Summary

We use an unusual file system at Google that allows writes (and
renames) but not deletions (for certain paths). That causes problems
when writing the requires files without atomictemp=True. There doesn't
appear to be any real drawbacks to using atomictemp, so I'm hoping we
can just change it in core.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Nov 14 2018, 3:05 PM
Closed by commit rHGacd17caa699a: requires: use atomictemp=True when writing .hg/requires (authored by martinvonz). · Explain WhyNov 14 2018, 3:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (2 lines)

Diff 12544

mercurial/scmutil.py

"data will be stored for %s.\n") "data will be stored for %s.\n")
% (repo.pathto(origsrc, cwd), repo.pathto(dst, cwd))) % (repo.pathto(origsrc, cwd), repo.pathto(dst, cwd)))
if repo.dirstate[dst] in '?r' and not dryrun: if repo.dirstate[dst] in '?r' and not dryrun:
wctx.add([dst]) wctx.add([dst])
elif not dryrun: elif not dryrun:
wctx.copy(origsrc, dst) wctx.copy(origsrc, dst)
def writerequires(opener, requirements): def writerequires(opener, requirements):
with opener('requires', 'w') as fp: with opener('requires', 'w', atomictemp=True) as fp:
for r in sorted(requirements): for r in sorted(requirements):
fp.write("%s\n" % r) fp.write("%s\n" % r)
class filecachesubentry(object): class filecachesubentry(object):
def __init__(self, path, stat): def __init__(self, path, stat):
self.path = path self.path = path
self.cachestat = None self.cachestat = None
self._cacheable = None self._cacheable = None