cleanupnodes: trust caller when "moves" is not None

Authored by martinvonz on Dec 6 2018, 12:12 AM.



If "moves" (indicating how to move bookmarks) is None, we fill it out
based on "replacements" (indicating which obsmarkers to add). If
"moves" is not None, we would still add items based on
"replacements". This makes it impossible to pass "moves={}" and not
move bookmarks, which surprised me. The only caller that currently
passes a value for "moves" was the rebase extension and there we were
already adding bookmark moves corresponding to obsmarker additions, so
it should not be impacted.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
martinvonz created this revision.Dec 6 2018, 12:12 AM
This revision was automatically updated to reflect the committed changes.