This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5517

tests: use more portable flags in test-fix.t
ClosedPublic

Authored by hooper on Jan 7 2019, 6:26 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd8f5c615e811: tests: use more portable flags in test-fix.t
Summary

head --lines N is known to not exist on OSX.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hooper created this revision.Jan 7 2019, 6:26 PM
Closed by commit rHGd8f5c615e811: tests: use more portable flags in test-fix.t (authored by hooper). · Explain WhyJan 7 2019, 6:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fix.py (4 lines)
Mtests/test-fix.t (8 lines)

Diff 13072

hgext/fix.py

When multiple tools are configured to affect a file, they execute in an order When multiple tools are configured to affect a file, they execute in an order
defined by the :priority suboption. The priority suboption has a default value defined by the :priority suboption. The priority suboption has a default value
of zero for each tool. Tools are executed in order of descending priority. The of zero for each tool. Tools are executed in order of descending priority. The
execution order of tools with equal priority is unspecified. For example, you execution order of tools with equal priority is unspecified. For example, you
could use the 'sort' and 'head' utilities to keep only the 10 smallest numbers could use the 'sort' and 'head' utilities to keep only the 10 smallest numbers
in a text file by ensuring that 'sort' runs before 'head':: in a text file by ensuring that 'sort' runs before 'head'::
[fix] [fix]
sort:command = sort --numeric-sort sort:command = sort -n
head:command = head --lines=10 head:command = head -n 10
sort:pattern = numbers.txt sort:pattern = numbers.txt
head:pattern = numbers.txt head:pattern = numbers.txt
sort:priority = 2 sort:priority = 2
head:priority = 1 head:priority = 1
To account for changes made by each tool, the line numbers used for incremental To account for changes made by each tool, the line numbers used for incremental
formatting are recomputed before executing the next tool. So, each tool may see formatting are recomputed before executing the next tool. So, each tool may see
different values for the arguments added by the :linerange suboption. different values for the arguments added by the :linerange suboption.

tests/test-fix.t

When multiple tools are configured to affect a file, they execute in an order When multiple tools are configured to affect a file, they execute in an order
defined by the :priority suboption. The priority suboption has a default value defined by the :priority suboption. The priority suboption has a default value
of zero for each tool. Tools are executed in order of descending priority. The of zero for each tool. Tools are executed in order of descending priority. The
execution order of tools with equal priority is unspecified. For example, you execution order of tools with equal priority is unspecified. For example, you
could use the 'sort' and 'head' utilities to keep only the 10 smallest numbers could use the 'sort' and 'head' utilities to keep only the 10 smallest numbers
in a text file by ensuring that 'sort' runs before 'head': in a text file by ensuring that 'sort' runs before 'head':
[fix] [fix]
sort:command = sort --numeric-sort sort:command = sort -n
head:command = head --lines=10 head:command = head -n 10
sort:pattern = numbers.txt sort:pattern = numbers.txt
head:pattern = numbers.txt head:pattern = numbers.txt
sort:priority = 2 sort:priority = 2
head:priority = 1 head:priority = 1
To account for changes made by each tool, the line numbers used for To account for changes made by each tool, the line numbers used for
incremental formatting are recomputed before executing the next tool. So, each incremental formatting are recomputed before executing the next tool. So, each
tool may see different values for the arguments added by the :linerange tool may see different values for the arguments added by the :linerange
implementation of fix). The goal is to use multiple tools to select the lowest implementation of fix). The goal is to use multiple tools to select the lowest
5 numbers in the file. 5 numbers in the file.
$ hg init priorityexample $ hg init priorityexample
$ cd priorityexample $ cd priorityexample
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [fix] > [fix]
> head:command = head --lines=5 > head:command = head -n 5
> head:pattern = numbers.txt > head:pattern = numbers.txt
> head:priority = 1 > head:priority = 1
> sort:command = sort --numeric-sort > sort:command = sort -n
> sort:pattern = numbers.txt > sort:pattern = numbers.txt
> sort:priority = 2 > sort:priority = 2
> EOF > EOF
$ printf "8\n2\n3\n6\n7\n4\n9\n5\n1\n0\n" > numbers.txt $ printf "8\n2\n3\n6\n7\n4\n9\n5\n1\n0\n" > numbers.txt
$ hg add -q $ hg add -q
$ hg fix -w $ hg fix -w
$ cat numbers.txt $ cat numbers.txt