Page MenuHomePhabricator

remotefilelog: add newlines to ui.log() invocations
ClosedPublic

Authored by spectral on Jan 8 2019, 5:51 PM.

Details

Summary

The comment at the top of ui.log() says that the message should be a
newline-terminated string. When using the blackbox logger, if the string does
not end in a newline, the appearance in the file gets quite messy.

This sometimes leaves a string with just the newline as the message, these are
logged by the blackbox logger just fine. I don't know what other loggers do when
logging structured data and a message that is just the newline.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Jan 8 2019, 5:51 PM
This revision was automatically updated to reflect the committed changes.