This is an archive of the discontinued Mercurial Phabricator instance.

tests: make HGCATAPULTSERVERPIPE imply HGTESTCATAPULTSERVERPIPE
ClosedPublic

Authored by spectral on Jan 10 2019, 10:29 PM.

Details

Summary

I had attempted to do this before, but missed this case. This makes it so that
one can do the following to get catapult traces that include both the .t test
name (and non-hg commands run by that .t test) *and* the hg-internal tracing, in
one trace:

HGCATAPULTSERVERPIPE=/tmp/catapult.pipe run-tests.py <args>

Without this change, we need to specify both HG{,TEST}CATAPULTSERVERPIPE; if
we specify just the TEST one, we only get the .t tests (no hg-internals), which
is working as intended. If we specify the non-TEST one, we only get the
hg-internals (not the rest of the .t test), which was not intended.

If you want to restore the previous behavior (just hg internals, not the stuff
from the .t tests), run like:

HGTESTCATAPULTSERVERPIPE=/dev/null \
  HGCATAPULTSERVERPIPE=/tmp/catapult.pipe \
  run-tests.py <args>

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Jan 10 2019, 10:29 PM
This revision was automatically updated to reflect the committed changes.