This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5639

context: delete mistaken comment about return value of renamed()
ClosedPublic

Authored by martinvonz on Jan 21 2019, 4:49 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG9087513df412: context: delete mistaken comment about return value of renamed()
Summary

The comment seems to think that the return value of renamed() is a
tuple of source pathsx in the parents, but it's actually a pair of
(rename source path, file nodeid).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 21 2019, 4:49 PM
Closed by commit rHG9087513df412: context: delete mistaken comment about return value of renamed() (authored by martinvonz). · Explain WhyJan 26 2019, 2:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (2 lines)

Diff 13489

mercurial/context.py

def memfilefromctx(ctx): def memfilefromctx(ctx):
"""Given a context return a memfilectx for ctx[path] """Given a context return a memfilectx for ctx[path]
This is a convenience method for building a memctx based on another This is a convenience method for building a memctx based on another
context. context.
""" """
def getfilectx(repo, memctx, path): def getfilectx(repo, memctx, path):
fctx = ctx[path] fctx = ctx[path]
# this is weird but apparently we only keep track of one parent
# (why not only store that instead of a tuple?)
copied = fctx.renamed() copied = fctx.renamed()
if copied: if copied:
copied = copied[0] copied = copied[0]
return memfilectx(repo, memctx, path, fctx.data(), return memfilectx(repo, memctx, path, fctx.data(),
islink=fctx.islink(), isexec=fctx.isexec(), islink=fctx.islink(), isexec=fctx.isexec(),
copied=copied) copied=copied)
return getfilectx return getfilectx