This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5741

tests: write commit message using file I/O
ClosedPublic

Authored by indygreg on Jan 29 2019, 5:37 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGc67f55b02f02: tests: write commit message using file I/O
rHG8dd0680d16cf: tests: write commit message using file I/O
Summary

Python 2.7 will print() \x94\x5c\x0a whereas Python 3 will
print() \xc2\x94\x5c\x0a. Why, I'm not sure. It probably has to
do with print() being Unicode aware on Python 3 and Python
attempting some kind of encoding before emitting the output.

This difference results in a different bytes making it to the
commit message and the JSON output varying. We work around
this by writing bytes to a commit message file.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jan 29 2019, 5:37 PM
Closed by commit rHG8dd0680d16cf: tests: write commit message using file I/O (authored by indygreg). · Explain WhyJan 30 2019, 2:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-hgweb-json.t (3 lines)

Diff 13573

tests/test-hgweb-json.t

{ {
"error": "unknown revision 'deadbeef'" "error": "unknown revision 'deadbeef'"
} }
[1] [1]
Commit message with Japanese Kanji 'Noh', which ends with '\x5c' Commit message with Japanese Kanji 'Noh', which ends with '\x5c'
$ echo foo >> da/foo $ echo foo >> da/foo
$ HGENCODING=cp932 hg ci -m `"$PYTHON" -c 'print("\x94\x5c")'` >>> open('msg', 'wb').write(b'\x94\x5c\x0a') and None
$ HGENCODING=cp932 hg ci -l msg
Commit message with null character Commit message with null character
$ echo foo >> da/foo $ echo foo >> da/foo
>>> open('msg', 'wb').write(b'commit with null character: \0\n') and None >>> open('msg', 'wb').write(b'commit with null character: \0\n') and None
$ hg ci -l msg $ hg ci -l msg
$ rm msg $ rm msg