This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5782

changegroup: don't try to prune manifest nodes if not ellipses
ClosedPublic

Authored by pulkit on Jan 31 2019, 12:13 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG5f9d057ba28c: changegroup: don't try to prune manifest nodes if not ellipses
Summary

In non-ellipses case, the number of manifest nodes can be very big, and finding
whether one of them can be pruned or not is very costly. For each node, we try
to find the rev and the linkrev, which is expensive.

Sending bit more manifest nodes seems better and much faster here. On our
internal repository, this saves around 5 seconds on `hg tracked --addinclude
<some_path>` on a narrow repo with ellipses disabled.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jan 31 2019, 12:13 PM
Closed by commit rHG5f9d057ba28c: changegroup: don't try to prune manifest nodes if not ellipses (authored by pulkit). · Explain WhyFeb 15 2019, 11:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (5 lines)

Diff 14129

mercurial/changegroup.py

store = mfl.getstorage(tree) store = mfl.getstorage(tree)
if not should_visit: if not should_visit:
# No nodes to send because this directory is out of # No nodes to send because this directory is out of
# the client's view of the repository (probably # the client's view of the repository (probably
# because of narrow clones). Do this even for the root # because of narrow clones). Do this even for the root
# directory (tree=='') # directory (tree=='')
prunednodes = [] prunednodes = []
elif not self._ellipses:
# In non-ellipses case and large repositories, it is better to
# prevent calling of store.rev and store.linkrev on a lot of
# nodes as compared to sending some extra data
prunednodes = nodes.copy()
else: else:
# Avoid sending any manifest nodes we can prove the # Avoid sending any manifest nodes we can prove the
# client already has by checking linkrevs. See the # client already has by checking linkrevs. See the
# related comment in generatefiles(). # related comment in generatefiles().
prunednodes = self._prunemanifests(store, nodes, commonrevs) prunednodes = self._prunemanifests(store, nodes, commonrevs)
if tree and not prunednodes: if tree and not prunednodes:
continue continue