This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5947

revlog: use iterbytestr()
ClosedPublic

Authored by indygreg on Feb 12 2019, 2:27 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf63ba0b9d06f: revlog: use iterbytestr()
rHG389ad992d953: revlog: use iterbytestr()
Summary

Otherwise we iterate over integers in Python 3 and the
character compare fails.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 12 2019, 2:27 PM
Closed by commit rHG389ad992d953: revlog: use iterbytestr() (authored by indygreg). · Explain WhyFeb 13 2019, 7:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (2 lines)

Diff 14064

mercurial/revlog.py

except error.WdirUnsupported: except error.WdirUnsupported:
# single 'ff...' match # single 'ff...' match
return True return True
if node is None: if node is None:
raise error.LookupError(node, self.indexfile, _('no node')) raise error.LookupError(node, self.indexfile, _('no node'))
return True return True
def maybewdir(prefix): def maybewdir(prefix):
return all(c == 'f' for c in prefix) return all(c == 'f' for c in pycompat.iterbytestr(prefix))
hexnode = hex(node) hexnode = hex(node)
def disambiguate(hexnode, minlength): def disambiguate(hexnode, minlength):
"""Disambiguate against wdirid.""" """Disambiguate against wdirid."""
for length in range(minlength, 41): for length in range(minlength, 41):
prefix = hexnode[:length] prefix = hexnode[:length]
if not maybewdir(prefix): if not maybewdir(prefix):