This is an archive of the discontinued Mercurial Phabricator instance.

record: avoid modifying the matcher passed as a method parameter
ClosedPublic

Authored by mharbison72 on May 11 2019, 10:56 PM.

Details

Summary

No problem observed, but I remember the previous pattern causing problems with
largefiles and/or subrepos. This special matcher was added in 419ac63fe29c, so
directly modifying the fail callback was probably an oversight in
44611ad4fbd9.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 11 2019, 10:56 PM
This revision was automatically updated to reflect the committed changes.