Page MenuHomePhabricator

py3: fix test-convert-svn-sink.t
ClosedPublic

Authored by pulkit on May 29 2019, 2:41 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGc004340dc687: py3: fix test-convert-svn-sink.t
Summary

In cases where the root commit is empty commit, None will be returned as
parents. This was implemented by 2c13e91ede6e.

This breaks test on py3 because b'%s' % None does not work. It does not matter
whether we return None or 'None' as we skipped converting to svn step by
doing an early return. So let's return 'None'.

I tried to patch all the users to convert None to 'None', but there were
more users than I expected. I hit 3 of them and decided to fix it this way
around.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.May 29 2019, 2:41 PM
This revision was automatically updated to reflect the committed changes.