This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6465

narrowspec: use vfs.tryread() instead of reimplementing
ClosedPublic

Authored by martinvonz on May 31 2019, 12:57 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG0c0a22f5b0b5: narrowspec: use vfs.tryread() instead of reimplementing
Summary

Note that parseconfig() works well with empty strings.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.May 31 2019, 12:57 PM
Closed by commit rHG0c0a22f5b0b5: narrowspec: use vfs.tryread() instead of reimplementing (authored by martinvonz). · Explain WhyJun 1 2019, 7:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/narrowspec.py (14 lines)

Diff 15321

mercurial/narrowspec.py

# narrowspec.py - methods for working with a narrow view of a repository # narrowspec.py - methods for working with a narrow view of a repository
# #
# Copyright 2017 Google, Inc. # Copyright 2017 Google, Inc.
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
import errno
from .i18n import _ from .i18n import _
from . import ( from . import (
error, error,
match as matchmod, match as matchmod,
merge, merge,
repository, repository,
scmutil, scmutil,
sparse, sparse,
" supported in narrowspec")) " supported in narrowspec"))
validatepatterns(includepats) validatepatterns(includepats)
validatepatterns(excludepats) validatepatterns(excludepats)
return includepats, excludepats return includepats, excludepats
def load(repo): def load(repo):
try:
spec = repo.svfs.read(FILENAME)
except IOError as e:
# Treat "narrowspec does not exist" the same as "narrowspec file exists # Treat "narrowspec does not exist" the same as "narrowspec file exists
# and is empty". # and is empty".
if e.errno == errno.ENOENT: spec = repo.svfs.tryread(FILENAME)
return set(), set()
raise
return parseconfig(repo.ui, spec) return parseconfig(repo.ui, spec)
def save(repo, includepats, excludepats): def save(repo, includepats, excludepats):
validatepatterns(includepats) validatepatterns(includepats)
validatepatterns(excludepats) validatepatterns(excludepats)
spec = format(includepats, excludepats) spec = format(includepats, excludepats)
repo.svfs.write(FILENAME, spec) repo.svfs.write(FILENAME, spec)