This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6960

run-tests: make coverage work out of tree
ClosedPublic

Authored by Kwan on Oct 4 2019, 1:21 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGe360acfaf210: run-tests: make coverage work out of tree
Summary

Currently coverage fails when run on an out-of-tree extension since
run-tests.py tries to load sitecustomize.py from self._testdir, which is the
dir for the extension's tests.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Oct 4 2019, 1:21 PM
Kwan added a commit: rHGe360acfaf210: run-tests: make coverage work out of tree.Oct 4 2019, 1:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGe360acfaf210: run-tests: make coverage work out of tree (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (2 lines)

Diff 16798

tests/run-tests.py

data = data.replace(br'"%~dp0..\python" "%~dp0hg" %*', data = data.replace(br'"%~dp0..\python" "%~dp0hg" %*',
b'"%~dp0python" "%~dp0hg" %*') b'"%~dp0python" "%~dp0hg" %*')
with open(hgbat, 'wb') as f: with open(hgbat, 'wb') as f:
f.write(data) f.write(data)
else: else:
print('WARNING: cannot fix hg.bat reference to python.exe') print('WARNING: cannot fix hg.bat reference to python.exe')
if self.options.anycoverage: if self.options.anycoverage:
custom = os.path.join(self._testdir, 'sitecustomize.py') custom = os.path.join(osenvironb[b'RUNTESTDIR'], 'sitecustomize.py')
target = os.path.join(self._pythondir, 'sitecustomize.py') target = os.path.join(self._pythondir, 'sitecustomize.py')
vlog('# Installing coverage trigger to %s' % target) vlog('# Installing coverage trigger to %s' % target)
shutil.copyfile(custom, target) shutil.copyfile(custom, target)
rc = os.path.join(self._testdir, '.coveragerc') rc = os.path.join(self._testdir, '.coveragerc')
vlog('# Installing coverage rc to %s' % rc) vlog('# Installing coverage rc to %s' % rc)
os.environ['COVERAGE_PROCESS_START'] = rc os.environ['COVERAGE_PROCESS_START'] = rc
covdir = os.path.join(self._installdir, '..', 'coverage') covdir = os.path.join(self._installdir, '..', 'coverage')
try: try: